Skip to content

Missing translation function call - #23911

Merged
nedbat merged 1 commit into
openedx:masterfrom
shadinaif:shadinaif/fix-untranslated-text
May 7, 2020
Merged

Missing translation function call#23911
nedbat merged 1 commit into
openedx:masterfrom
shadinaif:shadinaif/fix-untranslated-text

Conversation

@shadinaif

@shadinaif shadinaif commented May 6, 2020

Copy link
Copy Markdown
Contributor

A small change to get these texts translated. They always appear in English before this fix

@shadinaif
shadinaif requested a review from a team May 6, 2020 05:46
@openedx-webhooks

openedx-webhooks commented May 6, 2020

Copy link
Copy Markdown

Thanks for the pull request, @shadinaif! I've created OSPR-4471 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • edx-code email threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels May 6, 2020
@natabene

natabene commented May 6, 2020

Copy link
Copy Markdown
Contributor

@shadinaif Thank you for your contribution.

@natabene

natabene commented May 6, 2020

Copy link
Copy Markdown
Contributor

jenkins run all

@openedx-webhooks openedx-webhooks added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs triage labels May 6, 2020
@natabene

natabene commented May 6, 2020

Copy link
Copy Markdown
Contributor

@OmarIthawi Can you give this a look when you have a chance? CC @nedbat

@openedx-webhooks openedx-webhooks added awaiting prioritization and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels May 6, 2020
nedbat
nedbat suggested changes May 6, 2020
View reviewed changes
Comment thread common/lib/xmodule/xmodule/capa_base.py Outdated
OmarIthawi
OmarIthawi reviewed May 6, 2020
View reviewed changes

@OmarIthawi OmarIthawi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shadinaif. Besides Ned notes I have no other notes. Please tag me whenever the changes are ready.

@shadinaif
shadinaif force-pushed the shadinaif/fix-untranslated-text branch from c081fbf to 8156421 Compare May 7, 2020 11:30
@shadinaif
shadinaif force-pushed the shadinaif/fix-untranslated-text branch from 8156421 to 7142d55 Compare May 7, 2020 11:33
@shadinaif

shadinaif commented May 7, 2020

Copy link
Copy Markdown
Contributor Author

Ready @OmarIthawi

@natabene

natabene commented May 7, 2020

Copy link
Copy Markdown
Contributor

jenkins run all

OmarIthawi
OmarIthawi approved these changes May 7, 2020
View reviewed changes

@OmarIthawi OmarIthawi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Shadi! Looks good to me.

@edx-status-bot

edx-status-bot commented May 7, 2020

Copy link
Copy Markdown

Your PR has finished running tests. There were no failures.

@nedbat
nedbat merged commit 1fc881b into openedx:master May 7, 2020
@openedx-webhooks

openedx-webhooks commented May 7, 2020

Copy link
Copy Markdown

@shadinaif 🎉 Your pull request was merged!

Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot

edx-pipeline-bot commented May 7, 2020

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot

edx-pipeline-bot commented May 7, 2020

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@nedbat nedbat nedbat approved these changes
@OmarIthawi OmarIthawi OmarIthawi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

merged open-source-contribution PR author is not from Axim or 2U

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@shadinaif @openedx-webhooks @natabene @edx-status-bot @edx-pipeline-bot @nedbat @OmarIthawi